[webkit-reviews] review granted: [Bug 194620] Ignore Ad Click Attribution where source and destination are same-site : [Attachment 361950] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 194620: Ignore Ad Click Attribution where source and destination are
same-site
https://bugs.webkit.org/show_bug.cgi?id=194620

Attachment 361950: Patch

https://bugs.webkit.org/attachment.cgi?id=361950&action=review




--- Comment #3 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 361950
  --> https://bugs.webkit.org/attachment.cgi?id=361950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361950&action=review

LGTM except for the lack of the clarifications. John explained that to me
personally. Please add those explanations to the change log before landing.
r=me.

> Source/WebCore/ChangeLog:9
> +	   Updated existing test.

I guess some clarifications of the necessity of this patch is needed here.

> Source/WebCore/html/HTMLAnchorElement.cpp:449
> +    if (documentDomain == adDestinationHost) {

It is a bit unfortunate that platforms that don't have PUBLIC_SUFFIX_LIST get
different behaviors.