[webkit-reviews] review granted: [Bug 194576] generateUnlinkedCodeBlockForFunctions shouldn't need to create a FunctionExecutable just to get its source code : [Attachment 361919] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 194576: generateUnlinkedCodeBlockForFunctions shouldn't need to create a
FunctionExecutable just to get its source code
https://bugs.webkit.org/show_bug.cgi?id=194576

Attachment 361919: Patch

https://bugs.webkit.org/attachment.cgi?id=361919&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 361919
  --> https://bugs.webkit.org/attachment.cgi?id=361919
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361919&action=review

r=me

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:117
> +    SourceCode linkedSourceCode(const SourceCode&);

nit: I think this function can be marked const?