[webkit-reviews] review granted: [Bug 194527] Add two regression tests for reference cycle in IndexedDB : [Attachment 361809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 12 18:45:40 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 194527: Add two regression tests for reference cycle in IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=194527

Attachment 361809: Patch

https://bugs.webkit.org/attachment.cgi?id=361809&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 361809
  --> https://bugs.webkit.org/attachment.cgi?id=361809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361809&action=review

r=me

> LayoutTests/fast/dom/reference-cycle-leaks.html:120
> +// FIXME: Need to write this test and reorganize so it can be asynchronous.

Do we still need this FIXME?

What is "this test" in the FIXME?


More information about the webkit-reviews mailing list