[webkit-reviews] review granted: [Bug 194577] JSScript needs to retain its cache path NSURL* : [Attachment 361884] patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 194577: JSScript needs to retain its cache path NSURL*
https://bugs.webkit.org/show_bug.cgi?id=194577

Attachment 361884: patch

https://bugs.webkit.org/attachment.cgi?id=361884&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 361884
  --> https://bugs.webkit.org/attachment.cgi?id=361884
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361884&action=review

> Source/JavaScriptCore/API/JSScript.mm:132
> +    int fd = open(m_cachePath.get().path.UTF8String, O_RDONLY);

In WK2 we usually would just [m_cachePath path].UTF8String but it's up to you.