[webkit-reviews] review granted: [Bug 194355] [ews-app] Fetch builder id to name mapping : [Attachment 361319] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 12 15:17:24 PST 2019
Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 194355: [ews-app] Fetch builder id to name mapping
https://bugs.webkit.org/show_bug.cgi?id=194355
Attachment 361319: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=361319&action=review
--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 361319
--> https://bugs.webkit.org/attachment.cgi?id=361319
Proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=361319&action=review
> Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py:63
> + builder_id = builder['builderid']
do you want to use a .get here as well?
More information about the webkit-reviews
mailing list