[webkit-reviews] review granted: [Bug 194557] Find on Page shouldn't zoom in on matches : [Attachment 361841] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 12 14:27:30 PST 2019
Wenson Hsieh <wenson_hsieh at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 194557: Find on Page shouldn't zoom in on matches
https://bugs.webkit.org/show_bug.cgi?id=194557
Attachment 361841: Patch
https://bugs.webkit.org/attachment.cgi?id=361841&action=review
--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 361841
--> https://bugs.webkit.org/attachment.cgi?id=361841
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=361841&action=review
r=mews
> Source/WebKit/UIProcess/ios/SmartMagnificationController.mm:131
> +void SmartMagnificationController::scrollToRect(FloatPoint origin, FloatRect
targetRect)
Nit - could be const FloatPoint& and const FloatRect&. Do we also need
WebCore:: here?
More information about the webkit-reviews
mailing list