[webkit-reviews] review granted: [Bug 194549] Web Inspector: Timeline.prototype.recordsInTimeRange uses a property most records do not have : [Attachment 361818] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194549: Web Inspector: Timeline.prototype.recordsInTimeRange uses a
property most records do not have
https://bugs.webkit.org/show_bug.cgi?id=194549

Attachment 361818: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=361818&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361818
  --> https://bugs.webkit.org/attachment.cgi?id=361818
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361818&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Models/Timeline.js:99
> +	   let upperIndex = this._records.upperBound(endTime, (time, record) =>
time - record.startTime);

Should this be `endTime`?  If it's `startTime`, that means we'd include records
that began in the range, but finished outside of the range.  If it's `endTime`,
then we'd exclude those records.