[webkit-reviews] review granted: [Bug 194522] WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage : [Attachment 361735] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194522: WebPage::close needs to remove all message receivers associated
with that WebPage, not WebPage::~WebPage
https://bugs.webkit.org/show_bug.cgi?id=194522

Attachment 361735: Patch

https://bugs.webkit.org/attachment.cgi?id=361735&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 361735
  --> https://bugs.webkit.org/attachment.cgi?id=361735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361735&action=review

r=me with nits.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:40
> +    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 0.5*NSEC_PER_SEC),
dispatch_get_main_queue(), [retainedPage = retainPtr(browserContextController)]
{ });

I think we usually have spaces around the *

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2407
> +void testReuseSuspendedProcessForRegularNavigation(bool retainPageInBundle)

We usually use enum classes for such boolean parameters, see other tests in
this file.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2456
> +    testReuseSuspendedProcessForRegularNavigation(true);

Otherwise, call sites are not really readable.