[webkit-reviews] review granted: [Bug 194458] [Web GPU] DepthStencilAttachment implementation : [Attachment 361558] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 194458: [Web GPU] DepthStencilAttachment implementation
https://bugs.webkit.org/show_bug.cgi?id=194458

Attachment 361558: Patch

https://bugs.webkit.org/attachment.cgi?id=361558&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 361558
  --> https://bugs.webkit.org/attachment.cgi?id=361558
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361558&action=review

> Source/WebCore/Modules/webgpu/WebGPURenderPassDescriptor.h:43
> +struct WebGPURenderPassColorAttachmentDescriptor {
> +    RefPtr<WebGPUTextureView> attachment;

Could we use GPURenderPassColorAttachmentDescriptor for the rest of this
struct?

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:50
> +    }

Add ASSERT_NOT_REACHED, even though the compiler should error if this ever
happens.

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:55
> +    return MTLStoreActionStore;

Add an ASSERT