[webkit-reviews] review granted: [Bug 194365] Web Inspector: Timelines: clicking on an empty space in the overview should deselect any selected record bar : [Attachment 361425] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 194365: Web Inspector: Timelines: clicking on an empty space in the
overview should deselect any selected record bar
https://bugs.webkit.org/show_bug.cgi?id=194365

Attachment 361425: Patch

https://bugs.webkit.org/attachment.cgi?id=361425&action=review




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 361425
  --> https://bugs.webkit.org/attachment.cgi?id=361425
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361425&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordBar.js:392
> +	   // Ensure that the container "click" listener added by
`WI.TimelineOverview` isn't called.
> +	   event.__timelineRecordBarClick = true;

Can we just stop propagation?