[webkit-reviews] review granted: [Bug 192824] [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element : [Attachment 361632] Patch and layout tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 192824: [iOS] Keyups for non-modifier keys identified as "Dead" when not
focused in a content-editable element
https://bugs.webkit.org/show_bug.cgi?id=192824

Attachment 361632: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=361632&action=review




--- Comment #22 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 361632
  --> https://bugs.webkit.org/attachment.cgi?id=361632
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=361632&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3400
> +    if (!_page->editorState().isContentEditable) {

This seems like an acceptable workaround for now, but in general we should not
be relying on cached state in the UI process for correctness in asynchronous
methods like this.

Is there ever a case in which the editor state is not up to date when UIKit
asks us for this? I imagine that in -applyAutocorrection: it's probably okay,
but I suspect that when we first focus a field to summon the keyboard,
-requestAutocorrectionContextWithCompletionHandler: *might* be invoked before
our EditorState has arrived in the UI process.