[webkit-reviews] review granted: [Bug 194493] Remove the RELEASE_ASSERT check for duplicate cases in the BinarySwitch constructor. : [Attachment 361664] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 194493: Remove the RELEASE_ASSERT check for duplicate cases in the
BinarySwitch constructor.
https://bugs.webkit.org/show_bug.cgi?id=194493

Attachment 361664: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=361664&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 361664
  --> https://bugs.webkit.org/attachment.cgi?id=361664
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=361664&action=review

r=me

> Source/JavaScriptCore/jit/BinarySwitch.cpp:65
> +	   RELEASE_ASSERT(m_cases[i - 1] < m_cases[i], i, m_cases.size(),
m_cases[i].value, m_cases[i].index);

Why not using `ASSERT` here?