[webkit-reviews] review granted: [Bug 193622] [GTK][WPE] Add content extensions support in WKTR and unskip layout tests : [Attachment 361643] Patch v16

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 193622: [GTK][WPE] Add content extensions support in WKTR and unskip layout
tests
https://bugs.webkit.org/show_bug.cgi?id=193622

Attachment 361643: Patch v16

https://bugs.webkit.org/attachment.cgi?id=361643&action=review




--- Comment #67 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 361643
  --> https://bugs.webkit.org/attachment.cgi?id=361643
Patch v16

View in context: https://bugs.webkit.org/attachment.cgi?id=361643&action=review

Thu number of crashing tests is really huge, so while I'm OK with landing WKTR
support for content extensions now, we should look very closely at these
failures before deciding to expose the public API for 2.24.

> Tools/WebKitTestRunner/TestController.cpp:1376
> +#if !PLATFORM(COCOA)

Should also have a bug report to make the cross-platform implementation work
for Cocoa.