[webkit-reviews] review granted: [Bug 194053] BBQ-Air: Emit better code for switch : [Attachment 361616] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 194053: BBQ-Air: Emit better code for switch
https://bugs.webkit.org/show_bug.cgi?id=194053

Attachment 361616: patch

https://bugs.webkit.org/attachment.cgi?id=361616&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 361616
  --> https://bugs.webkit.org/attachment.cgi?id=361616
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361616&action=review

r=me

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1528
>	   unifyValuesWithBlock(expressionStack,
targets[i]->resultForBranch());

Use `for (const ControlData& target : targets)` instead.

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1539
> +    for (size_t i = 0; i < targets.size(); ++i)

Ditto.

> Source/JavaScriptCore/wasm/WasmAirIRGenerator.cpp:1574
> +	   params.addLatePath([=] (CCallHelpers& jit) {

Is WTFMove(caseJumps) & WTFMove(successorLabels) better?