[webkit-reviews] review granted: [Bug 194473] [LFC][IFC] Add intrinsic width support for basic inline containers : [Attachment 361607] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 9 10:25:43 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 194473: [LFC][IFC] Add intrinsic width support for basic inline containers
https://bugs.webkit.org/show_bug.cgi?id=194473

Attachment 361607: Patch

https://bugs.webkit.org/attachment.cgi?id=361607&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 361607
  --> https://bugs.webkit.org/attachment.cgi?id=361607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361607&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:138
> +void InlineFormattingContext::computeBorderAndPadding(const Box& layoutBox,
UsedHorizontalValues usedValues) const
> +{
> +    auto& displayBox = layoutState().displayBoxForLayoutBox(layoutBox);
> +    displayBox.setBorder(Geometry::computedBorder(layoutBox));
> +    displayBox.setPadding(Geometry::computedPadding(layoutBox, usedValues));
> +}

This is in addition to FormattingContext::computeBorderAndPadding, right? Is
there something inline specific here?


More information about the webkit-reviews mailing list