[webkit-reviews] review granted: [Bug 194466] [JSC] String.fromCharCode's slow path always generates 16bit string : [Attachment 361577] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 18:58:32 PST 2019


Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 194466: [JSC] String.fromCharCode's slow path always generates 16bit string
https://bugs.webkit.org/show_bug.cgi?id=194466

Attachment 361577: Patch

https://bugs.webkit.org/attachment.cgi?id=361577&action=review




--- Comment #2 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 361577
  --> https://bugs.webkit.org/attachment.cgi?id=361577
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361577&action=review

r=me with small fix.

> Source/JavaScriptCore/ChangeLog:10
> +	   and even worse, taints ropes 16bit if 16bit string is included in
the given rope. We find that acorn-wtb

Typo: We find => We found. Or if you want to take more credit: I found.

> Source/JavaScriptCore/ChangeLog:12
> +	   16bit string. However, only few strings are actually 16bit strings.
This patch attempts to make 8bit string

Typo: only few => only a few

> Source/JavaScriptCore/runtime/StringConstructor.cpp:91
> +	   if (UNLIKELY(character & 0xFF00)) {

Can we use or create a named WTF function for this?


More information about the webkit-reviews mailing list