[webkit-reviews] review canceled: [Bug 194427] Add SPI to use networking daemon instead of XPC service : [Attachment 361554] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 16:07:30 PST 2019


Alex Christensen <achristensen at apple.com> has canceled Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194427: Add SPI to use networking daemon instead of XPC service
https://bugs.webkit.org/show_bug.cgi?id=194427

Attachment 361554: Patch

https://bugs.webkit.org/attachment.cgi?id=361554&action=review




--- Comment #13 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 361554
  --> https://bugs.webkit.org/attachment.cgi?id=361554
Patch

I put the SPI header definitions in the correct sections, moved the
__APPLEEVENTSSERVICENAME setting to before the "bootstrap" event handling, and
put the whole "bootstrap" event handler in a std::call_once because it sets the
environment that we won't be able to set with the second xpc connection to a
daemon.


More information about the webkit-reviews mailing list