[webkit-reviews] review granted: [Bug 194461] [ews-build] Ensure that every builder in config.json has short name : [Attachment 361548] Proposed patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 194461: [ews-build] Ensure that every builder in config.json has short name
https://bugs.webkit.org/show_bug.cgi?id=194461

Attachment 361548: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=361548&action=review




--- Comment #2 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 361548
  --> https://bugs.webkit.org/attachment.cgi?id=361548
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361548&action=review

> Tools/BuildSlaveSupport/ews-build/loadConfig.py:105
> +	   raise Exception('Builder "{}" does not have short name defined. This
name is needed for EWS status-bubbles.'.format(builder.get('name')))

I don't think status bubbles should be hyphenated.

> Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py:113
> +	   self.assertEqual(context.exception.args, ('Builder "mac-wk2(test)"
does not have short name defined. This name is needed for EWS
status-bubbles.',))

ditto