[webkit-reviews] review requested: [Bug 194459] Web Inspector: Debugger Popover should work with value in template string `${identifier}` : [Attachment 361550] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 8 15:56:30 PST 2019
Joseph Pecoraro <joepeck at webkit.org> has asked for review:
Bug 194459: Web Inspector: Debugger Popover should work with value in template
string `${identifier}`
https://bugs.webkit.org/show_bug.cgi?id=194459
Attachment 361550: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=361550&action=review
--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 361550
--> https://bugs.webkit.org/attachment.cgi?id=361550&action=review
[PATCH] Proposed Fix
Tested with:
<script>
setTimeout(() => {
document.body.onclick = () => {
let before = "test";
let array = [1, 2, 3];
console.log(`before ${array} after ${array.length}`);
debugger;
};
});
</script>
• Was able to hover and get popovers inside of these:
${array} and ${array.length}
• Did not get a popover when hovering the "before" in `before ...`.
More information about the webkit-reviews
mailing list