[webkit-reviews] review granted: [Bug 190997] [WebIDL] Support serializing sequences and FrozenArrays of non-interfaces : [Attachment 361462] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 190997: [WebIDL] Support serializing sequences and FrozenArrays of
non-interfaces
https://bugs.webkit.org/show_bug.cgi?id=190997

Attachment 361462: Patch

https://bugs.webkit.org/attachment.cgi?id=361462&action=review




--- Comment #10 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 361462
  --> https://bugs.webkit.org/attachment.cgi?id=361462
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361462&action=review

r=me

> Source/WebCore/ChangeLog:14
> +	   left that as a follow-up task, since I don't see any IDLs that
currently need this.

If there are specs that support this idea, I think we should file a Bugzilla
now that tracks this, and reference it in your FIXME comment.

But, if no IDL needs this at all I guess we don't have to track work that isn't
even conceptually needed.

> Source/WebCore/bindings/scripts/CodeGenerator.pm:957
> +	   # FIXME: Teach GenerateSerializerDefinition to serialize sequences
of interfaces, then remove this line.

FIXME(Bug), please...