[webkit-reviews] review granted: [Bug 187723] [Cocoa] Ask platform for generic font family mappings : [Attachment 361078] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 8 08:38:12 PST 2019

Brent Fulgham <bfulgham at webkit.org> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 187723: [Cocoa] Ask platform for generic font family mappings

Attachment 361078: Patch


--- Comment #83 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 361078
  --> https://bugs.webkit.org/attachment.cgi?id=361078

View in context: https://bugs.webkit.org/attachment.cgi?id=361078&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:-1723
> -

Doesn't seem like we need this change.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:1070
> +	   if (RefPtr<CSSValue> parsedValue = consumeGenericFamily(range))

Could this be auto?

>> Source/WebCore/platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp:217
> This is supposed to be in platform.h

I don't understand this statement. What is? The PLATFORM macro?

More information about the webkit-reviews mailing list