[webkit-reviews] review denied: [Bug 191645] [Curl] Implement Cookie Accept Policy. : [Attachment 361383] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 8 05:27:03 PST 2019
Fujii Hironori <Hironori.Fujii at sony.com> has denied review:
Bug 191645: [Curl] Implement Cookie Accept Policy.
https://bugs.webkit.org/show_bug.cgi?id=191645
Attachment 361383: Patch
https://bugs.webkit.org/attachment.cgi?id=361383&action=review
--- Comment #5 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 361383
--> https://bugs.webkit.org/attachment.cgi?id=361383
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=361383&action=review
> Source/WebCore/platform/network/curl/CookieJarDB.cpp:311
> + // FIXME : Support cookie policy.
Umm, I don't understand your answer (comment 4).
The problem of this patch is the most important part is unimplemented (this
FIXME).
Basically, it is a good practice to split a large patch into some patches.
However, this patch seems too small to understand.
I want to see the implementation.
More information about the webkit-reviews
mailing list