[webkit-reviews] review denied: [Bug 194411] [Mac] WebInspectorUI.framework does not need to be soft-linked anymore : [Attachment 361440] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Brian Burg <bburg at apple.com>'s
request for review:
Bug 194411: [Mac] WebInspectorUI.framework does not need to be soft-linked
anymore
https://bugs.webkit.org/show_bug.cgi?id=194411

Attachment 361440: Patch

https://bugs.webkit.org/attachment.cgi?id=361440&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 361440
  --> https://bugs.webkit.org/attachment.cgi?id=361440
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361440&action=review

> Source/WebKit/Configurations/WebKit.xcconfig:131
> +WK_WEBINSPECTORUI_LDFLAGS =
$(WK_WEBINSPECTORUI_LDFLAGS_$(WK_PLATFORM_NAME));
> +WK_WEBINSPECTORUI_LDFLAGS_macosx = -framework WebInspectorUI;

I don't think we can hard link WebInspectorUI as it doesn't look like
WebInspectorUI.framework is available in the Base System.