[webkit-reviews] review granted: [Bug 194362] Add afterScreenUpdates to WKSnapshotConfiguration : [Attachment 361450] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 14:55:04 PST 2019

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 194362: Add afterScreenUpdates to WKSnapshotConfiguration

Attachment 361450: Patch


--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 361450
  --> https://bugs.webkit.org/attachment.cgi?id=361450

View in context: https://bugs.webkit.org/attachment.cgi?id=361450&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKSnapshotConfiguration.h:51
> + at property (nonatomic) BOOL afterScreenUpdates

Obviously need to review this name.

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1188
> +    if (snapshotConfiguration && snapshotConfiguration.afterScreenUpdates) {

This could be inverted and be an early return (after calling callSnapshotRect),
and then the code below could be outdented one line 🤷‍♂️ don't care

More information about the webkit-reviews mailing list