[webkit-reviews] review granted: [Bug 194240] Filter out Overconstrainederror.constraint when getUserMedia is not granted : [Attachment 361417] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 194240: Filter out Overconstrainederror.constraint when getUserMedia is not
granted
https://bugs.webkit.org/show_bug.cgi?id=194240

Attachment 361417: Patch

https://bugs.webkit.org/attachment.cgi?id=361417&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 361417
  --> https://bugs.webkit.org/attachment.cgi?id=361417
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361417&action=review

> Source/WebKit/ChangeLog:8
> +	   Make sure in UIProcess to filter out constraint if either the page
had not gum granted

Nit: "filter out constraint if either the page had not gum granted" => "filter
out the failed constraint name if either the page has not granted gUM"

> Source/WebKit/ChangeLog:9
> +	   or it has not persistent access.

Nit: "it has not persistent access" => "it does not have persistent access"