[webkit-reviews] review granted: [Bug 194364] Print backgrounds preference should be honored instead of WKWebViewConfiguration value : [Attachment 361408] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 10:46:42 PST 2019


Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194364: Print backgrounds preference should be honored instead of
WKWebViewConfiguration value
https://bugs.webkit.org/show_bug.cgi?id=194364

Attachment 361408: Patch

https://bugs.webkit.org/attachment.cgi?id=361408&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 361408
  --> https://bugs.webkit.org/attachment.cgi?id=361408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361408&action=review

> Source/WebKit/ChangeLog:15
> +	   * UIProcess/API/Cocoa/WKWebView.mm:

You need to explain the long-term cleanup plan either here or in the bug, and
there should be a new bug tracking it.


More information about the webkit-reviews mailing list