[webkit-reviews] review granted: [Bug 191303] DumpRenderTree should report unknown options : [Attachment 361302] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 7 00:59:58 PST 2019


Frédéric Wang (:fredw) <fred.wang at free.fr> has granted darshan
<dkadu at igalia.com>'s request for review:
Bug 191303: DumpRenderTree should report unknown options
https://bugs.webkit.org/show_bug.cgi?id=191303

Attachment 361302: Patch

https://bugs.webkit.org/attachment.cgi?id=361302&action=review




--- Comment #41 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 361302
  --> https://bugs.webkit.org/attachment.cgi?id=361302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361302&action=review

> Tools/DumpRenderTree/TestOptions.h:50
> +    // Fixme: support following test options is not implemented

nit: it should be uppercase FIXME. And ideally refer to a but number
https://webkit.org/b/????


More information about the webkit-reviews mailing list