[webkit-reviews] review granted: [Bug 194363] Digital crown should scroll safe browsing warning on watchOS : [Attachment 361336] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 6 17:51:31 PST 2019

Wenson Hsieh <wenson_hsieh at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 194363: Digital crown should scroll safe browsing warning on watchOS

Attachment 361336: Patch


--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 361336
  --> https://bugs.webkit.org/attachment.cgi?id=361336

View in context: https://bugs.webkit.org/attachment.cgi?id=361336&action=review

> Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:38
> +#import <UIKit/UIResponder_Private.h>

Nit - I think you can just import "UIKitSPI.h" instead.

> Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm:296
> +    self.crownInputScrollDirection = PUICCrownInputScrollDirectionVertical;

Nice, you took out the scrollIndicator = NO :)

I was about to tell you that we actually want to show scroll indicators in
native UI here, but it looks like you beat me to it.

More information about the webkit-reviews mailing list