[webkit-reviews] review granted: [Bug 194277] [JSC] PrivateName to PublicName hash table is wasteful : [Attachment 361284] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 194277: [JSC] PrivateName to PublicName hash table is wasteful
https://bugs.webkit.org/show_bug.cgi?id=194277

Attachment 361284: Patch

https://bugs.webkit.org/attachment.cgi?id=361284&action=review




--- Comment #21 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 361284
  --> https://bugs.webkit.org/attachment.cgi?id=361284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361284&action=review

r=me with some suggested comment and whitespace changes.

> Source/JavaScriptCore/ChangeLog:9
> +	   PrivateNames take much memory in intial JSC footprint. Since
BuiltinNames have Identifier fields corresponding to these PrivateNames,
> +	   sizeof(BuiltinNames) is about 6KB. It also maintains hash tables for
"PublicName to PrivateName" and "PrivateName to PublicName",

Wording seems a little awkward.  How about:
    PrivateNames account for a lot of memory in the initial JSC footprint.
BuiltinNames have Identifier fields corresponding to these PrivateNames 
    which makes the sizeof(BuiltinNames) about 6KB. ...

> Source/JavaScriptCore/ChangeLog:16
> +	   2. If PrivateName is not actually a private name (we introduced
hacky mapping like "@iteratorSymbol" => Symbol.iterator),

Did you mean "If PrivateName is not actually a *public* name ..."?

> Source/JavaScriptCore/runtime/CommonIdentifiers.cpp:64
> +    

Delete this extraneous whitespace.