[webkit-reviews] review granted: [Bug 194293] Web Inspector: DOM: don't send the entire function string with each event listener : [Attachment 361307] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 6 11:28:12 PST 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 194293: Web Inspector: DOM: don't send the entire function string with each
event listener
https://bugs.webkit.org/show_bug.cgi?id=194293
Attachment 361307: Patch
https://bugs.webkit.org/attachment.cgi?id=361307&action=review
--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 361307
--> https://bugs.webkit.org/attachment.cgi?id=361307
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=361307&action=review
r=me
> Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:1684
> + if (auto handleEventValue = handlerObject->get(exec,
JSC::Identifier::fromString(exec, "handleEvent")))
This can cause an exception which may need to handled... that said this is all
in Web Inspector code which would just ignore the exception.
More information about the webkit-reviews
mailing list