[webkit-reviews] review granted: [Bug 194319] Web Inspector: "Worker not found" uncaught protocol errors : [Attachment 361248] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 16:52:44 PST 2019

Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194319: Web Inspector: "Worker not found" uncaught protocol errors

Attachment 361248: [PATCH] Proposed Fix


--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 361248
  --> https://bugs.webkit.org/attachment.cgi?id=361248
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=361248&action=review


> Source/WebInspectorUI/ChangeLog:12
> +	   frame, but for now this is the only a page transition can kill

Grammar: "the only a page" -> "the only way a page"

> Source/WebInspectorUI/UserInterface/Base/Main.js:232
> +    let workerTargets = WI.targets.filter((x) => x.type ===

Nit: rename x to target.

More information about the webkit-reviews mailing list