[webkit-reviews] review granted: [Bug 191303] DumpRenderTree should report unknown options : [Attachment 361201] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted darshan
<dkadu at igalia.com>'s request for review:
Bug 191303: DumpRenderTree should report unknown options
https://bugs.webkit.org/show_bug.cgi?id=191303

Attachment 361201: Patch

https://bugs.webkit.org/attachment.cgi?id=361201&action=review




--- Comment #38 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 361201
  --> https://bugs.webkit.org/attachment.cgi?id=361201
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361201&action=review

> Tools/DumpRenderTree/TestOptions.h:49
> +    bool enableCSSCustomPropertiesAndValues { false };

Please address add a FIXME:

(In reply to Frédéric Wang (:fredw) from comment #36)
> Currently the new values are not used at all, so you should add a FIXME and
> open a separate bug if you don't plan to fix that in this bug.
> 
> For Web Preferences, you can probably get the default values from
> Source/WebKit/Shared/WebPreferences.yaml and only need to initialize them in
> setWebPreferencesForTestOptions from
> Tools/DumpRenderTree/mac/DumpRenderTree.mm