[webkit-reviews] review granted: [Bug 194264] [ews-app] Add method to save BuilderMapping to database : [Attachment 361145] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 09:07:58 PST 2019

Lucas Forschler <lforschler at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 194264: [ews-app] Add method to save BuilderMapping to database

Attachment 361145: Proposed patch


--- Comment #3 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 361145
  --> https://bugs.webkit.org/attachment.cgi?id=361145
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361145&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/buildermapping.py:59
> +	       _log.error('builder_id {} does not match with builer_id {}.
Ignoring new data.'.format(mapping.builder_id, builder_id))

nit: typo: builer

More information about the webkit-reviews mailing list