[webkit-reviews] review granted: [Bug 194269] [LFC][IFC] collectInlineContent should use pre-computed margins, paddings and borders : [Attachment 361151] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 5 07:30:53 PST 2019


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 194269: [LFC][IFC] collectInlineContent should use pre-computed margins,
paddings and borders
https://bugs.webkit.org/show_bug.cgi?id=194269

Attachment 361151: Patch

https://bugs.webkit.org/attachment.cgi?id=361151&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 361151
  --> https://bugs.webkit.org/attachment.cgi?id=361151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361151&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:158
> -    unsigned m_baseTypeFlags : 4;
> +    unsigned m_baseTypeFlags : 5;

OptionSet would avoid these problems too!


More information about the webkit-reviews mailing list