[webkit-reviews] review granted: [Bug 194270] JITExecutable should not try to mmap executable memory without entitlement : [Attachment 361153] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 194270: JITExecutable should not try to mmap executable memory without
entitlement
https://bugs.webkit.org/show_bug.cgi?id=194270

Attachment 361153: Patch

https://bugs.webkit.org/attachment.cgi?id=361153&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 361153
  --> https://bugs.webkit.org/attachment.cgi?id=361153
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361153&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   We try to use our one time token to map JIT memory if we are not
> +	   going to use the JIT in a process. If we never had the

This sentence makes it seem like we only do this if we don't have the
entitlement. I think you can make it clearer.