[webkit-reviews] review denied: [Bug 194254] Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page : [Attachment 361142] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 194254: Web Inspector: REGRESSION (r240947): Resources tab: can't select
main frame after refreshing page
https://bugs.webkit.org/show_bug.cgi?id=194254

Attachment 361142: Patch

https://bugs.webkit.org/attachment.cgi?id=361142&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361142
  --> https://bugs.webkit.org/attachment.cgi?id=361142
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361142&action=review

r-, can you write some sort of test for this?  I think we've long passed the
point where we need regression tests for our common UI classes.

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:825
> +		   const omitFocus = true;

This doesn't seem right.  If we try to select a `WI.TreeElement` via
`_handleMouseDown`, we'd never focus the parent.  Either provide a
justification for this, or maybe be a bit more "limiting" (e.g. only
`omitFocus` when there is more than one `selectedItems`).