[webkit-reviews] review granted: [Bug 194169] Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll : [Attachment 361082] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 194169: Web Inspector: REGRESSION: clicking a selected call frame doesn't
re-scroll
https://bugs.webkit.org/show_bug.cgi?id=194169

Attachment 361082: Patch

https://bugs.webkit.org/attachment.cgi?id=361082&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 361082
  --> https://bugs.webkit.org/attachment.cgi?id=361082
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361082&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:1018
> +	   if (this.allowsRepeatSelection && !this.allowsMultipleSelection &&
treeElement.selected) {

Is there a reason/example why we don't want to have this behavior of multiple
selection is enabled?  I think we should be a bit more "selective" (no pun
intended), in that if we do allow multiple selection, but only have one item
selected, re-selecting it would also fire an event.  Just because we have
`allowsMultipleSelection`, doesn't mean we should blanket prevent this
behavior.