[webkit-reviews] review granted: [Bug 194190] [CG] Enable setAdditionalSupportedImageTypes for WK1 : [Attachment 361087] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 13:37:39 PST 2019

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 194190: [CG] Enable setAdditionalSupportedImageTypes for WK1

Attachment 361087: Patch


--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 361087
  --> https://bugs.webkit.org/attachment.cgi?id=361087

View in context: https://bugs.webkit.org/attachment.cgi?id=361087&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:1192
> +- (void)setAdditionalSupportedImageTypes: (NSArray<NSString *> *)imageTypes

:<no space>(

Also, it's funny that you're being so careful with the type checks when reading
out of prefs but not when writing to them.

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:629
> +// The input of this SPI is an array of image UTI (Uniform Type Identifier).

I would leave off "the input of this SPI". Maybe just
"additionalSupportedImageTypes is an array of image UTIs".

More information about the webkit-reviews mailing list