[webkit-reviews] review granted: [Bug 192305] [WPE] Add API for webview background color configuration : [Attachment 361048] Rebased patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 09:09:21 PST 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 192305: [WPE] Add API for webview background color configuration

Attachment 361048: Rebased patch


--- Comment #27 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 361048
  --> https://bugs.webkit.org/attachment.cgi?id=361048
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=361048&action=review

This looks good to me, but this still needs owner approval. The changes here
are extensive.

> Source/WebKit/Shared/WebPageCreationParameters.cpp:354
>  #endif
> +    Optional<Optional<WebCore::Color>> backgroundColor;

There should be a blank line here.

> Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:1142
> +#define ColorType GdkRGBA
> +#elif PLATFORM(WPE)
> +#define ColorType WebKitColor
> +#endif

using ColorType = GdkRGBA;
using ColorType = WebKitColor;

More information about the webkit-reviews mailing list