[webkit-reviews] review denied: [Bug 194007] [JSC][BigEndians] Several JSC stress tests failing : [Attachment 360569] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 4 08:59:44 PST 2019


Saam Barati <sbarati at apple.com> has denied Tomas Popela <tpopela at redhat.com>'s
request for review:
Bug 194007: [JSC][BigEndians] Several JSC stress tests failing
https://bugs.webkit.org/show_bug.cgi?id=194007

Attachment 360569: Patch

https://bugs.webkit.org/attachment.cgi?id=360569&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 360569
  --> https://bugs.webkit.org/attachment.cgi?id=360569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360569&action=review

> JSTests/ChangeLog:8
> +	   Skip these tests when JIT is not enabled, as they require it.

This is definitely not right. DataView exists with the JIT off. Why not just
fix the test to be endian agnostic? Alternatively, I’m ok with you skipping if
it’s not a little endian architecture


More information about the webkit-reviews mailing list