[webkit-reviews] review granted: [Bug 194184] Async overflow scroll is jumpy if the main thread is busy : [Attachment 360963] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 194184: Async overflow scroll is jumpy if the main thread is busy
https://bugs.webkit.org/show_bug.cgi?id=194184

Attachment 360963: Patch

https://bugs.webkit.org/attachment.cgi?id=360963&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 360963
  --> https://bugs.webkit.org/attachment.cgi?id=360963
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360963&action=review

> Source/WebCore/ChangeLog:3
> +	   Async overflow scroll is jumpy if the main thread is busy

"on Mac"

> Source/WebCore/rendering/RenderLayerBacking.cpp:1759
> -	   m_scrollingContentsLayer->setPaintingPhase(paintPhase);
> -	   m_scrollingLayer->addChild(*m_scrollingContentsLayer);
> +	   m_scrolledContentsLayer->setPaintingPhase(paintPhase);
> +	   m_scrollingLayer->addChild(*m_scrolledContentsLayer);

Could have also renamed m_scrollingLayer -> m_scrollContainerLayer