[webkit-reviews] review granted: [Bug 194187] [JSC] Decouple JIT related data from CodeBlock : [Attachment 360957] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 21:53:59 PST 2019

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 194187: [JSC] Decouple JIT related data from CodeBlock

Attachment 360957: Patch


--- Comment #5 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 360957
  --> https://bugs.webkit.org/attachment.cgi?id=360957

View in context: https://bugs.webkit.org/attachment.cgi?id=360957&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1364
>  void CodeBlock::finalizeBaselineJITInlineCaches()

Don’t we want to be holding the lock while iterating these data structures?

> Source/JavaScriptCore/bytecode/CodeBlock.h:989
> +    std::unique_ptr<JITData> m_jitData;

Why not just put this on the base class for JITCode for baseline and above? It
would save us one pointer stored in CodeBlock

More information about the webkit-reviews mailing list