[webkit-reviews] review granted: [Bug 194125] [WebGPU] Fix GPURenderPassEncoder::setVertexBuffers and allow overlapping indices with GPUBindGroups : [Attachment 360811] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 194125: [WebGPU] Fix GPURenderPassEncoder::setVertexBuffers and allow
overlapping indices with GPUBindGroups
https://bugs.webkit.org/show_bug.cgi?id=194125

Attachment 360811: Patch

https://bugs.webkit.org/attachment.cgi?id=360811&action=review




--- Comment #3 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 360811
  --> https://bugs.webkit.org/attachment.cgi?id=360811
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360811&action=review

>
Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h:42
> +} // namespace Metal
> +
> +} // namespace WHLSL
> +
> +} // namespace WebCore

Ending comments unnecessary when the file is so short

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPassEncoderMetal.mm:108
> +    [m_platformRenderPassEncoder setVertexBuffers:mtlBuffers.data()
offsets:(const NSUInteger *)offsets.data() withRange:indexRanges];

wow

> Source/WebCore/platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:33
> +#import "WHLSLVertexBufferIndexCalculator.h"

👍