[webkit-reviews] review denied: [Bug 193878] AX: VoiceOver allows to interact with a disabled <select> element : [Attachment 360903] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Eric Liang
<ericliang at apple.com>'s request for review:
Bug 193878: AX: VoiceOver allows to interact with a disabled <select> element
https://bugs.webkit.org/show_bug.cgi?id=193878

Attachment 360903: Patch

https://bugs.webkit.org/attachment.cgi?id=360903&action=review




--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 360903
  --> https://bugs.webkit.org/attachment.cgi?id=360903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360903&action=review

> Source/WebCore/accessibility/AccessibilityMenuList.cpp:52
> +	   RenderMenuList* menuList = downcast<RenderMenuList>(renderer());
> +	   if (menuList->popupIsVisible())

You should use is<RenderMenuList>(renderer()) here; is<> does the type check
and the null pointer check for you.