[webkit-reviews] review granted: [Bug 193740] REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html : [Attachment 360883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 1 14:12:52 PST 2019


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 193740: REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state ==
State::Committed on
http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-if
rame-in-cross-origin-page.html
https://bugs.webkit.org/show_bug.cgi?id=193740

Attachment 360883: Patch

https://bugs.webkit.org/attachment.cgi?id=360883&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 360883
  --> https://bugs.webkit.org/attachment.cgi?id=360883
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=360883&action=review

> Source/WebCore/loader/PolicyChecker.cpp:219
> +	       function({ }, nullptr, { }, { }, ShouldContinue::No);

If this were before Ignore it could just assert then fall through.


More information about the webkit-reviews mailing list