[webkit-reviews] review granted: [Bug 194171] Web Inspector: Make WI.ColumnChart a WI.View subclass : [Attachment 360890] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 1 13:36:50 PST 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 194171: Web Inspector: Make WI.ColumnChart a WI.View subclass
https://bugs.webkit.org/show_bug.cgi?id=194171
Attachment 360890: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=360890&action=review
--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360890
--> https://bugs.webkit.org/attachment.cgi?id=360890
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=360888&action=review
rs=me
> Source/WebInspectorUI/UserInterface/Views/ColumnChart.js:51
> + this._svgElement =
this.element.appendChild(createSVGElement("svg"));
I think it's worth adding `preservesAspectRatio="none"` like many of the other
charts, so that if we ever use it elsewhere it also supports stretching.
this._svgElement.setAttribute("preserveAspectRatio", "none");
More information about the webkit-reviews
mailing list