[webkit-reviews] review requested: [Bug 193838] Web Inspector: REGRESSION: selecting a path component with no siblings does nothing : [Attachment 360150] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 193838: Web Inspector: REGRESSION: selecting a path component with no
siblings does nothing
https://bugs.webkit.org/show_bug.cgi?id=193838

Attachment 360150: Patch

https://bugs.webkit.org/attachment.cgi?id=360150&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 360150
  --> https://bugs.webkit.org/attachment.cgi?id=360150
Patch

(In reply to Matt Baker from comment #2)
> We rely on allowsRepeatSelection in the Debugger tab Call Stack tree.
> Selecting an already selected element should scroll the source code location
> into view. This change breaks that behavior.
This is currently not working for me on ToT.  I don't think that issue has
anything to do with this.  If anything, this change should help that, because
by removing `allowsRepeatSelection`, we're effectively setting it to `true` for
all `WI.TreeOutline`, so we should _always_ be able to reselect (and therefore
re-scroll).  Resetting to r?.