[webkit-reviews] review granted: [Bug 194146] [WPE] MiniBrowser: use g_file_new_for_commandline_arg : [Attachment 360850] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 1 01:59:41 PST 2019
Xabier RodrÃguez Calvar <calvaris at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 194146: [WPE] MiniBrowser: use g_file_new_for_commandline_arg
https://bugs.webkit.org/show_bug.cgi?id=194146
Attachment 360850: Patch
https://bugs.webkit.org/attachment.cgi?id=360850&action=review
--- Comment #3 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 360850
--> https://bugs.webkit.org/attachment.cgi?id=360850
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=360850&action=review
> Tools/MiniBrowser/wpe/main.cpp:206
> + GFile* file = g_file_new_for_commandline_arg(uriArguments[0]);
> + char* url = g_file_get_uri(file);
I'd recommend using smart pointers for this
More information about the webkit-reviews
mailing list