[webkit-reviews] review granted: [Bug 205614] Allow disabling internal and experimental features in run-webkit-tests : [Attachment 386465] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 28 10:00:56 PST 2019


Tim Horton <thorton at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 205614: Allow disabling internal and experimental features in
run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=205614

Attachment 386465: patch

https://bugs.webkit.org/attachment.cgi?id=386465&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 386465
  --> https://bugs.webkit.org/attachment.cgi?id=386465
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386465&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:122
> +	       help="Enable (disable) an internal feature (--internal-feature
FeatureEnabled[=true|false])"),

s/FeatureEnabled/FeatureName/, I think. I read it wrong the first three times
and had to read the changelog to understand.


More information about the webkit-reviews mailing list