[webkit-reviews] review granted: [Bug 205546] WKTR/DRT always trigger the Discrete GPU on dual GPU systems : [Attachment 386392] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 205546: WKTR/DRT always trigger the Discrete GPU on dual GPU systems
https://bugs.webkit.org/show_bug.cgi?id=205546

Attachment 386392: Patch

https://bugs.webkit.org/attachment.cgi?id=386392&action=review




--- Comment #15 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 386392
  --> https://bugs.webkit.org/attachment.cgi?id=386392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=386392&action=review

> Tools/ChangeLog:9
> +	   Add an option "--prefer-integrated-gpu" to run-webkit-test

I'm not a fan of this name either, because the preference is not about
impacting what WebKit prefers to use. WebKit will do its thing, which is now
something different from it was before, and the policy can certainly change in
the future. I want this to more closely match what run-webkit-tests code does,
not what WebKit does.

Maybe allow-integrated-gpu?